Improvements to django.contrib.auth
#246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation doesn't suggest that None is valid.
Any custom user model should inherit from AbstractUser
Not a whole Collection
This way AbstractUser has access to the special methods on UserManager
sbdchd
reviewed
May 31, 2024
| ) -> None: ... | ||
|
|
||
| class User(AbstractUser): |
There was a problem hiding this comment.
It's not deleted, it's just moved down to line 111
sbdchd
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The highlight of this PR is changing
get_user_model()to returntype[AbstractUser], which much more useful thantype[AbstractBaseUser].See commits for details and commentary.